Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add cloudUrl to addRun response #2539

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: add cloudUrl to addRun response #2539

merged 1 commit into from
Jul 4, 2023

Conversation

hugorut
Copy link
Contributor

@hugorut hugorut commented Jul 4, 2023

resolves issue where workflow CI users cannot see the "View in Infracost dashboard".

@hugorut hugorut self-assigned this Jul 4, 2023
@hugorut hugorut marked this pull request as ready for review July 4, 2023 10:56
@hugorut hugorut requested review from vdmgolub and removed request for vdmgolub July 4, 2023 10:56
@hugorut hugorut marked this pull request as draft July 4, 2023 10:57
@hugorut
fix: add cloudUrl to addRun response
affc4f9 
resolves issue where workflow CI users cannot see the "View in Infracost dashboard".
@hugorut hugorut marked this pull request as ready for review July 4, 2023 10:58
@hugorut hugorut requested a review from vdmgolub July 4, 2023 10:58
vdmgolub
vdmgolub approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@vdmgolub vdmgolub left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The k8s files are not supposed to be in the PR, right?

@hugorut hugorut merged commit b78a58e into master Jul 4, 2023
10 checks passed
@hugorut hugorut deleted the fix/cloud-url branch July 4, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdmgolub vdmgolub vdmgolub approved these changes

Assignees

@hugorut hugorut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugorut @vdmgolub