updated github.go to check /api/v3 | issue> #1980 #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshneydevansh
commented
Jul 5, 2023
aliscott
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Thanks @varshneydevansh. Test failures look unrelated so this is good to go.
|
Thank you so much, @aliscott |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue> Validate --github-api-url #1980
Sorry again, creating the PR for this issue as I also added the update for the other file of other issue with the same branch which got added with this PR. I was trying to create a new PR for the other issue, but eventually ended-up discarding all the changes. When I saw the PR it was showing closed.
I added the check for the "/api/v3" for the github-api-url to make sure we remain consistent with the link.
Thanks, Ali Khajeh and Alistair Scott for helping and guiding with my second open-source contribution.