refactor: change auto detect logic to include tfvars #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugorut
force-pushed
the
refactor/auto-detect-improvements
branch
3 times, most recently
from
eb24137
to
b647542
Compare
Changes auto detection logic so that terraform var files are automatically taken into consideration: 1. If a single terraform var file is found under a project, we add it to the evaluator 2. If more than one are found under a project, we split the project into multiples. One for each var file discovered. This functionality is solely for auto detection and once a user defines a config file, we no longer adhear to these rules.
hugorut
force-pushed
the
refactor/auto-detect-improvements
branch
from
b647542
to
bdab661
Compare
aliscott
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Looks great.
Not needed for just now, but this got me thinking if we could do something more intelligent here to determine if the var file is a project-specific var file or a shared/global var file. Maybe this could work by looking at the variable names within the var file and seeing if there's multiple overlapping keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes auto detection logic so that terraform var files are automatically taken into consideration:
This functionality is solely for auto detection and once a user defines a config file, we no longer adhear to these rules.
Also added a
jsoniterrefactor into this pr to speed up the parsing logic. Let me know if you want me to separate it out.