feat: Combine cost and tag policies comment output #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
approved these changes
Jul 13, 2023
| @@ -161,6 +161,9 @@ func ToMarkdown(out Root, opts Options, markdownOpts MarkdownOptions) ([]byte, e | |||
| "showProject": func(p Project) bool { | |||
| return showProject(p, opts, false) | |||
| }, | |||
| "cloudURL": func() string { | |||
There was a problem hiding this comment.
Does this need to be a function?
There was a problem hiding this comment.
I couldn't see another way to pass the value from the toplevel template to the sub-template.
vdmgolub
reviewed
Jul 13, 2023
| Failing Tag Policy: This should show as a failure | ||
| module.hosted_cloud_pricing_api.aws_s3_bucket.cloud_pricing_api_db_data in project(s) my-dev-project, my-other-project-with-same-violations | ||
| - should have mandatory tags: "Environment", "Team" | ||
| - should have a valid value for "Team" tag: "Ops", "Frontend team", "Backend team" |
There was a problem hiding this comment.
@tim775 Do we want to keep this copy as is or update it to follow the same "Missing mandatory tags"/"Invalid value..." messages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.