Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent mock values #2570

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Consistent mock values #2570

merged 3 commits into from
Jul 13, 2023

Conversation

aliscott
Copy link
Member

This ensures mocks are calculated deterministically and so resource checksums are also consistent between runs.

@aliscott aliscott requested review from hugorut and removed request for hugorut July 13, 2023 08:16
@aliscott aliscott marked this pull request as draft July 13, 2023 08:16
@aliscott aliscott marked this pull request as ready for review July 13, 2023 08:56
@aliscott aliscott requested a review from hugorut July 13, 2023 08:57
@aliscott
Copy link
Member Author

Test failure looks unrelated

hugorut
hugorut approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do this with child blocks as well?

@aliscott
Copy link
Member Author

Do we need to do this with child blocks as well?

As far as I can tell the child blocks are already consistently ordered.

@aliscott aliscott merged commit a72d25a into master Jul 13, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugorut hugorut hugorut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aliscott @hugorut