Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HCL graph tests #2783

Merged
merged 4 commits into from Feb 19, 2024
Merged

feat: add HCL graph tests #2783

merged 4 commits into from Feb 19, 2024

Conversation

hugorut
Copy link
Contributor

@hugorut hugorut commented Dec 10, 2023

Adds coverage for HCL graph evaluator. Also removes the onlyRunCLI option for the test suite as this is not used.

hugorut and others added 2 commits February 15, 2024 14:20
Adds coverage for HCL graph evaluator. Also removes the onlyRunCLI option
for the test suite as this is not used.
This fixes the missing variable warnings which should use the unfiltered blocks.
@aliscott aliscott force-pushed the feat/add-graph-tests branch 3 times, most recently from 2d90201 to 5331a28 Compare February 16, 2024 10:09
Since we're running the graph evaluator and legacy evaluator we need to update some tests
that have mocking functionality to support being run multiple times.
@aliscott aliscott force-pushed the feat/add-graph-tests branch 2 times, most recently from 1b59cb8 to d460a1b Compare February 16, 2024 13:12
This allows us to keep running the tests in parallel
@aliscott aliscott marked this pull request as ready for review February 16, 2024 16:08
@aliscott
Copy link
Member

@hugorut can you give this a review please?

Copy link
Contributor Author

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice

@aliscott aliscott self-requested a review February 17, 2024 10:22
@aliscott aliscott merged commit 38a6856 into master Feb 19, 2024
9 of 10 checks passed
@aliscott aliscott deleted the feat/add-graph-tests branch February 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants