Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(google): Generate guest accelerator name/desc prefix programmatically #2883

Merged
merged 3 commits into from Feb 16, 2024

Conversation

vdmgolub
Copy link
Contributor

Fixes #2797.

@vdmgolub vdmgolub self-assigned this Feb 15, 2024
@vdmgolub vdmgolub force-pushed the enhance/gcp-add-nvidia-l4-accelerator branch from 5057810 to a8a1644 Compare February 16, 2024 10:09
@vdmgolub vdmgolub changed the title enhance(gcp): Add NVIDIA L4 GPU guest accelerator refactor(google): Generate guest accelerator name/desc prefix programmatically Feb 16, 2024
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

@vdmgolub vdmgolub merged commit 7f54b03 into master Feb 16, 2024
10 checks passed
@vdmgolub vdmgolub deleted the enhance/gcp-add-nvidia-l4-accelerator branch February 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guest_accelerator.type 'nvidia-l4' is not supported
2 participants