Refactor: migration Azure resources #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
force-pushed
the
refactor-migration-azure-batch3-alistair
branch
from
c316a3a
to
d8fb55d
Compare
aliscott
commented
Feb 25, 2024
internal/providers/terraform/azure/testdata/image_test/image_test.golden
Show resolved
Hide resolved
aliscott
changed the title
hugorut
approved these changes
Feb 26, 2024
internal/providers/terraform/azure/frontdoor_firewall_policy.go
Outdated
Show resolved
Hide resolved
aliscott
force-pushed
the
refactor-migration-azure-batch3-alistair
branch
from
aa35232
to
e9dc372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening @sinabakh's previous work in #1851, since we want to add new resources that depend on the Azure Virtual Machines cost components. This migrates several Azure resources to the newer provider-agnostic format.
I've fixed these up to add any new cost component lookup fixes, and also fixed panics that were happening with the previous PR.
Outside the scope of this PR: