fix: ensure expressions that expect bools return bools #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliscott
force-pushed
the
fix-conditional-expr-mock
branch
3 times, most recently
from
4a00cfe
to
4d18f69
Compare
hugorut
reviewed
Feb 28, 2024
internal/hcl/attribute.go
Outdated
Comment on lines
601
to
602
| lhsParam := params[0] | ||
| rhsParam := params[1] |
There was a problem hiding this comment.
is this always expected to be a slice of this size?
There was a problem hiding this comment.
we should make add a size check just in case?
There was a problem hiding this comment.
Yeah, all BinaryOp functions have 2 params, but updated this anyway to make sure.
aliscott
force-pushed
the
fix-conditional-expr-mock
branch
from
4d18f69
to
b232fb9
Compare
hugorut
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a logical expression (|| or &&) had a sub-expression that was mocked to a non-boolean value, this would always mean the expression always returned false. We now handle this in the same way that we had condition expressions to ensure the mocked expressions return a boolean value if the operator expects boolean values.