Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't remove child of errored prior projects that exist in current #3019

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tim775
Copy link
Member

@tim775 tim775 commented Apr 17, 2024

If a nested terragrunt project has syntax errors, the error is reported at the parent project path. To prevent the child project from appearing as "removed" when diff'd against a baseline without the syntax error, we search for and remove child projects of the parent path. BUT, since some child projects may have been processed successfully, we should only remove past children that don't exist in the current.

@tim775 tim775 requested a review from hugorut April 17, 2024 06:17
@tim775 tim775 self-assigned this Apr 17, 2024
Copy link
Contributor

@hugorut hugorut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tim775 tim775 merged commit dd39675 into master Apr 17, 2024
9 of 10 checks passed
@tim775 tim775 deleted the fix/handle_nested_terragrunt_errors branch April 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants