feat(aws): Refactored CPU credits to use usage file. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikhajeh1
reviewed
Apr 29, 2021
infracost-usage-example.yml
Outdated
Comment on lines
53
to
55
| # Only used when T2 credit_specification is set to unlimited or T3 & T4 instance types are used within a launch template, or T3 & T4 instance types in a launch configuration. | ||
| cpu_credit_hrs: 350 # Number of hours in the month where you expect to burst the instance | ||
| virtual_cpu_count: 2 # Number of vCPUs that the instance type as. |
There was a problem hiding this comment.
Suggested change
| # Only used when T2 credit_specification is set to unlimited or T3 & T4 instance types are used within a launch template, or T3 & T4 instance types in a launch configuration. | |
| cpu_credit_hrs: 350 # Number of hours in the month where you expect to burst the instance | |
| virtual_cpu_count: 2 # Number of vCPUs that the instance type as. | |
| # Only applicable when T2 credit_specification is set to unlimited, or T3 & T4 instance types are used within a launch template, or T3 & T4 instance types are used in a launch configuration. | |
| monthly_cpu_credit_hrs: 350 # Number of hours in the month where the instance is expected to burst. | |
| virtual_cpu_count: 2 # Number of the vCPUs for the instance type. |
|
Thanks @robh007! Added my comments, mainly trying to cleanup old inconsistencies 😅 |
added 2 commits
April 30, 2021 21:38
|
@alikhajeh1 I've updated as requested. |
|
Thanks @robh007! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #554
Allows usage data to be provided for the following resources.
aws_autoscaling_groupbothaws_launch_configurations&aws_launch_templatesaws_eks_node_groupaws_instanceThe following values can now be added to your usage file, to estimate EC2 CPU credit usage over a given month.