Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure): add support for VPN Gateway #901

Merged
merged 26 commits into from
Aug 13, 2021
Merged

feat(azure): add support for VPN Gateway #901

merged 26 commits into from
Aug 13, 2021

Conversation

praveenghuge
Copy link
Contributor

@praveenghuge praveenghuge commented Aug 8, 2021 •
edited

@praveenghuge
Merged from upstream
1945c3c
@praveenghuge
Merge remote-tracking branch 'upstream/master'
c46fe52
@praveenghuge
Merge branch 'infracost:master' into master
e6ea6ad
@praveenghuge
Merge branch 'infracost:master' into master
f403b6f
@praveenghuge
Merge branch 'infracost:master' into master
b2ab7c0
@praveenghuge
add issue tempalte
fe4eb00
@praveenghuge
revert invalid changes
7e31d8f
@praveenghuge
revert invalid changes
97180e7
@praveenghuge
Merge branch 'infracost:master' into master
477946a
@praveenghuge
vpn gateway initial commit
ba67dfa
@praveenghuge
remove unwanted files
912767b
@praveenghuge
add new line
fcc084c
@praveenghuge
add usage based cost
d757423
@praveenghuge
Merge branch 'infracost:master' into master
7a20fde
@praveenghuge
add usage charges
c44fbb7
@praveenghuge
chore(azure): make fmt
df11258
@praveenghuge
Merge branch 'master' of github.com:praveenghuge/infracost into vpn_g…
af7a4ac 
…ateway
@praveenghuge
chore(azure): remove unwanted print statement
397dd85
@praveenghuge
fix liniting
754439b
@praveenghuge
fix comment
ec603b5
@praveenghuge
fix pric
42ca39b
@alikhajeh1 alikhajeh1 self-assigned this Aug 9, 2021
@alikhajeh1
Copy link
Member

@praveenghuge thank you! I'll review this week.

tim775
tim775 requested changes Aug 11, 2021
View reviewed changes
internal/providers/terraform/azure/testdata/vpn_gateway_test/vpn_gateway_test.golden Outdated Show resolved Hide resolved
internal/providers/terraform/azure/testdata/vpn_gateway_test/vpn_gateway_test.golden Outdated Show resolved Hide resolved
internal/providers/terraform/azure/testdata/vpn_gateway_test/vpn_gateway_test.golden Outdated Show resolved Hide resolved
internal/providers/terraform/azure/testdata/vpn_gateway_test/vpn_gateway_test.golden Outdated Show resolved Hide resolved
infracost-usage-example.yml Outdated Show resolved Hide resolved
internal/providers/terraform/azure/vpn_gateway.go Outdated Show resolved Hide resolved
infracost-usage-example.yml Outdated Show resolved Hide resolved
internal/providers/terraform/azure/vpn_gateway.go Outdated Show resolved Hide resolved
internal/providers/terraform/azure/vpn_gateway.go Outdated Show resolved Hide resolved
internal/providers/terraform/azure/vpn_gateway.go Outdated Show resolved Hide resolved
tim775
tim775 requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@tim775 tim775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick turn around! One quick change and then I think it's done.

I'll create a new issue for adding costs for azurerm_virtual_network_gateway_connection so we don't lose track of it.

internal/providers/terraform/azure/vpn_gateway.go Outdated Show resolved Hide resolved
@tim775 tim775 merged commit 5d2aa70 into infracost:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliscott aliscott aliscott left review comments

@tim775 tim775 tim775 approved these changes

Assignees

@praveenghuge praveenghuge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@praveenghuge @alikhajeh1 @tim775 @aliscott