-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add currency conversion #914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I added my suggestions. We should update https://www.infracost.io/docs/multi_project/report to include the currency in the JOSN output.
I'm not sure we need the "$ CAD" on every line as it clutters the output in the table and the HTML outputs:
Project: infracost/infracost/examples/terraform
Name Monthly Qty Unit Monthly Cost
aws_instance.web_app
├─ Instance usage (Linux/UNIX, on-demand, m5.4xlarge) 730 hours $0.00 CAD
├─ root_block_device
│ └─ Storage (general purpose SSD, gp2) 50 GB $0.00 CAD
└─ ebs_block_device[0]
├─ Storage (provisioned IOPS SSD, io1) 1,000 GB $0.00 CAD
└─ Provisioned IOPS 800 IOPS $0.00 CAD
aws_lambda_function.hello_world
├─ Requests Monthly cost depends on usage: $0.00 CAD per 1M requests
└─ Duration Monthly cost depends on usage: $0.00 CAD per GB-seconds
OVERALL TOTAL $0.00 CAD
How about we only include it in the OVERALL TOTAL, or maybe only in the headings: "Price (CAD)", "Hourly Cost (CAD)" and "Monthly Cost (CAD)"?
Project: infracost/infracost/examples/terraform
Name Monthly Qty Unit Monthly Cost (CAD)
aws_instance.web_app
├─ Instance usage (Linux/UNIX, on-demand, m5.4xlarge) 730 hours $0.00
├─ root_block_device
│ └─ Storage (general purpose SSD, gp2) 50 GB $0.00
└─ ebs_block_device[0]
├─ Storage (provisioned IOPS SSD, io1) 1,000 GB $0.00
└─ Provisioned IOPS 800 IOPS $0.00
aws_lambda_function.hello_world
├─ Requests Monthly cost depends on usage: $0.00 per 1M requests
└─ Duration Monthly cost depends on usage: $0.00 per GB-seconds
OVERALL TOTAL $0.00
For the diff output, we could include it in the project diff total:
Monthly cost change for infracost/infracost/examples/terraform
Amount: $0.00 CAD ($0.00 -> $0.00)
Co-authored-by: Ali Khajeh-Hosseini <alikhajeh1@googlemail.com>
Co-authored-by: Ali Khajeh-Hosseini <alikhajeh1@googlemail.com>
Co-authored-by: Ali Khajeh-Hosseini <alikhajeh1@googlemail.com>
Co-authored-by: Ali Khajeh-Hosseini <alikhajeh1@googlemail.com>
212c2f2
to
2c4fefb
Compare
Thanks @tim775 - this is looking awesome. The HTML format ( There seems to be a bug in the way
Expected behavior: the simplest thing is probably to have |
Co-authored-by: Ali Khajeh-Hosseini <alikhajeh1@googlemail.com>
7f09f61
to
53f89be
Compare
No description provided.