Option to use HTTP GET requests instead of POST #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changed adds a new option to the Client contructor called `http_get`, which is a boolean defaulting to False. If this option is set to True, the Client would contruct a URL for a HTTP GET request instead of the otherwise used POST request (determined if a caller provides the `data` parameter or not). According to the OAI-PMH standard both methods are allowed. But I came a long yet another fauly implementation, where POST would not work, only GET does. This flag is a workaround that might come in handy for others as well.
|
If you are okay with this PR, it probably needs a little bit of documentation, don't know where I should add such things. |
|
Fixes #11 |
|
@jascoul thanks for your feedback. I changed the name of the param. |
jascoul
added a commit
that referenced
this pull request
Dec 18, 2015
Option to use HTTP GET requests instead of POST
|
@jascoul Do you consider to create a new release on PyPI soonish? It would be great to get the latest changes as a regular release that I can use as a dependency in my projects. It's been already more than 5 years since the last release... If you need help maintaining the codebase, I'm happy to help. |
|
@metaodi Yes, it's been a while, I agree. I've just made a new release on PyPI with your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changed adds a new option to the Client contructor called
http_get, which is a boolean defaulting to False.If this option is set to True, the Client would construct a URL for a
HTTP GET request instead of the otherwise used POST request (determined
if a caller provides the
dataparameter or not). According to theOAI-PMH standard both methods are allowed. But I came across yet
another faulty implementation, where POST would not work, only GET does.
This flag is a workaround that might come in handy for others as well.