-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signup also saves into list of previous logged in orgs #3165
Conversation
ui/pages/signup/index.js
Outdated
@@ -53,6 +55,18 @@ export default function Signup() { | |||
let created = await res.json() | |||
|
|||
window.location = `${window.location.protocol}//${created?.organization?.domain}` | |||
let visitedOrgs = cookies.get('orgs') || [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the same logic as in the login page, it would be nice to add a shared helper function (maybe in the libs folder) so if we want to change this in the future we know there is one central place to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, other than the one comment 👍
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
* feat: prelogin page that lists orgs that were logged into, using cookies * improve: small * improve: origin to host, use // * improve: small * improve: small * improve: push package.json * improve: reorganized imports * improve: small * improve: small * improve: small * improve: small * improve: small * feat: signup also saves into list of previous logged in orgs * improve: helper fn * improve: small Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com> Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
After user successfully signs up and logs out from the dashboard,
they will see the new org in the list of visited orgs on
login.infrahq.com/login/organizations
(using cookies).