feat: signup also saves into list of previous logged in orgs #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceMacD
reviewed
Sep 9, 2022
ui/pages/signup/index.js
Outdated
| @@ -53,6 +55,18 @@ export default function Signup() { | |||
| let created = await res.json() | |||
|
|
|||
| window.location = `${window.location.protocol}//${created?.organization?.domain}` | |||
| let visitedOrgs = cookies.get('orgs') || [] | |||
There was a problem hiding this comment.
Looks like this is the same logic as in the login page, it would be nice to add a shared helper function (maybe in the libs folder) so if we want to change this in the future we know there is one central place to do so.
BruceMacD
approved these changes
Sep 16, 2022
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
jmorganca
pushed a commit
that referenced
this pull request
Sep 19, 2022
* feat: prelogin page that lists orgs that were logged into, using cookies * improve: small * improve: origin to host, use // * improve: small * improve: small * improve: push package.json * improve: reorganized imports * improve: small * improve: small * improve: small * improve: small * improve: small * feat: signup also saves into list of previous logged in orgs * improve: helper fn * improve: small Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com> Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After user successfully signs up and logs out from the dashboard,
they will see the new org in the list of visited orgs on
login.infrahq.com/login/organizations(using cookies).