Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintain: updated docs as per jeffs comments #3270

Merged
merged 2 commits into from
Sep 20, 2022
Merged

maintain: updated docs as per jeffs comments #3270

merged 2 commits into from
Sep 20, 2022

Conversation

technovangelist
Copy link
Contributor

Signed-off-by: Matt Williams m@technovangelist.com

Summary

continuing to update the docs

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #

@technovangelist
updated docs as per jeffs comments
f3bdc69 
Signed-off-by: Matt Williams <m@technovangelist.com>
@technovangelist technovangelist mentioned this pull request Sep 19, 2022
Merged
7 tasks
jmorganca
jmorganca reviewed Sep 20, 2022
View reviewed changes
docs/start/quickstart.md Outdated

## Signup to Create a New Organization
## 1) Signup to Create a New Organization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use 1. (preferred) across the docs or 1)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@technovangelist
Use new nextjs image component
adf4272 
Updated all images to use css shadow supported in new nextjs
image component

Signed-off-by: Matt Williams <m@technovangelist.com>
@vercel vercel bot temporarily deployed to Preview September 20, 2022 20:47 Inactive
@technovangelist technovangelist merged commit 64ef836 into main Sep 20, 2022
@technovangelist technovangelist deleted the matt/newdocs2 branch September 20, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca approved these changes

@dnephin dnephin Awaiting requested review from dnephin

@pdevine pdevine Awaiting requested review from pdevine

@mchiang0610 mchiang0610 Awaiting requested review from mchiang0610

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@technovangelist @jmorganca