maintain: update documentation #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Williams <m@technovangelist.com>
Signed-off-by: Matthew Williams <m@technovangelist.com>
Signed-off-by: Matthew Williams <m@technovangelist.com>
Signed-off-by: Matt Williams <m@technovangelist.com>
technovangelist
requested review from
dnephin,
jmorganca,
pdevine and
mchiang0610
as code owners
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
mxyng
approved these changes
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
jmorganca
reviewed
Sep 19, 2022
Signed-off-by: Matt Williams <m@technovangelist.com>
Signed-off-by: Matt Williams <m@technovangelist.com>
jmorganca
requested review from
hoyyeva,
BruceMacD and
kimskimchi
as code owners
Signed-off-by: Matt Williams <m@technovangelist.com>
jmorganca
force-pushed
the
matt/newdocs
branch
from
58f3297
to
b8faa5c
Compare
Signed-off-by: Matt Williams <m@technovangelist.com>
jmorganca
reviewed
Sep 19, 2022
| @@ -38,8 +40,10 @@ body, | |||
| @apply prose-pre:py-4; | |||
| @apply prose-pre:min-w-full; | |||
| @apply prose-pre:font-medium; | |||
| @apply prose-img:rounded-lg; | |||
| @apply prose-img:bg-gray-700/5; | |||
| /* @apply prose-img:rounded-lg; */ | |||
jmorganca
reviewed
Sep 19, 2022
| /* @apply prose-img:rounded-lg; */ | ||
| /* @apply prose-img:bg-gray-700/5; */ | ||
| /* @apply prose-img:border-2; | ||
| @apply prose-img:drop-shadow-lg; */ |
There was a problem hiding this comment.
This may not be visible due to overflow – we could try:
@apply prose-img:overflow-visible;
jmorganca
reviewed
Sep 19, 2022
| @@ -8,7 +8,9 @@ body, | |||
| @apply h-full; | |||
| @apply antialiased; | |||
| } | |||
|
|
|||
| .prose-docs > img { | |||
There was a problem hiding this comment.
This would be better as a tailwind rule as below
There was a problem hiding this comment.
i forgot i added that.... trying to get anything to work
jmorganca
reviewed
Sep 19, 2022
| permanent: true, | ||
| }, | ||
|
|
||
| ...[ |
There was a problem hiding this comment.
Great idea with the spread operator here
jmorganca
reviewed
Sep 19, 2022
|
|
||
| {% callout type="info" %} | ||
|
|
||
| We are slowly rolling out our SaaS product. If you are interested in onboarding before we open it up completely, let us know. Until then you can [install the self-hosted version of the Infra Server](../reference/selfhosted.md). |
There was a problem hiding this comment.
Great callout! Let's link this to a signup form once that's ready vs sending to self-hosted
There was a problem hiding this comment.
send me the signup form and it will be done
jmorganca
reviewed
Sep 19, 2022
| --- | ||
| # Quickstart | ||
|
|
||
| Infra is rolling out it's Software as a Service offering which makes it easier than ever to setup infrastructure access for your organization. This page will show you everything you need to do to get started. |
There was a problem hiding this comment.
These two paragraphs are a ton of frontmatter that may not help the user get started. Let's help them get started!
There was a problem hiding this comment.
take a look at #3270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the documentation to be SaaS-first, dashboard-first.
Checklist
Related Issues
Resolves #