fix(deps): update module github.com/micahparks/keyfunc/v2 to v3 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
After updating the imports to use the new v3 package the following errors happen: So this will require some additional work to update to this new v3 package. |
keyfunc/v3 had some significant changes which moved much of the configuration and logic to the jwkset library. As such much of the configuration moved with it and so our configuration needed to change. This updates the code to use this new configuration method. Tests, with only small changes continue to pass. Signed-off-by: Mike Mason <mimason@equinix.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
nicolerenee
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.1.0->v3.3.2Release Notes
MicahParks/keyfunc (github.com/MicahParks/keyfunc/v2)
v3.3.2: Allow for user provided ctx during parseCompare Source
The purpose of this release is to add a new method,
.KeyfuncCtx.This new method accepts a
context.Context, then returns ajwt.Keyfunc. This user providedcontext.Contextis used during JWK lookup in thegithub.com/MicahParks/jwksetpackage when parsing JWTs. Passing a request scoped context allows the JWT parsing and JWK retrieval to cancel according to the givencontext.Contextbehavior instead of the defaultcontext.Context, which was provided atkeyfunc.Keyfuncinitialization.In practice, this is used to prevent situations where many JWTs with
kidnot in a remote JWK Set are attempting to be parsed over a long period of time.Relevant issues:
Relevant pull requests:
v3.3.1Compare Source
v3.3.0Compare Source
v3.2.9Compare Source
v3.2.8Compare Source
v3.2.7Compare Source
v3.2.6Compare Source
v3.2.5Compare Source
v3.2.4Compare Source
v3.2.3: Wrap errors where appropriateCompare Source
The purpose of this pull request is to wrap errors with
errors.Joinwhere appropriate.Relevant issues:
Relevant pull requests:
v3.1.2: X.509 Thumbprint bug fixCompare Source
JWK Sets have two X.509 thumbprint parameters that are optional. A bug in
github.com/MicahParks/jwksetmade these parameters required in circumstances that affect thekeyfuncproject. This release updates this dependency to the latest version.Thank you, @joshkaplinsky, for reporting this bug!
Please see the below release for details:
https://github.com/MicahParks/jwkset/releases/tag/v0.5.5
v3.1.1Compare Source
v3.1.0Compare Source
v3.0.0: V3 simplify API by using github.com/MicahParks/jwksetCompare Source
This upgrade removes most of the code in this repository and outsources JWK and JWK Set related code to the updated github.com/MicahParks/jwkset package. The exported assets from the keyfunc project has been vastly reduced as well, with the intention of making it easier to use for the majority of use cases.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.