Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Split brain resolver #178

Merged
merged 49 commits into from
Nov 30, 2018
Merged

WIP: Split brain resolver #178

merged 49 commits into from
Nov 30, 2018

Conversation

bekiroguz
Copy link
Collaborator

No description provided.

bekiroguz and others added 30 commits August 20, 2018 17:51
@bekiroguz
created initial version of the SplitBrainResolver algorithm TLA speci…
a3d0c0b 
…fication
@bekiroguz
SBR algorithm from the first node's perspective
3473d4a
@bekiroguz
added a README file and changed the Initial state
6c5c10a
@bekiroguz
run the same algorithm from 2 to N nr of members
1d7bcaa
@bekiroguz
small refactorings on readability and debugging
54b06ba
@bekiroguz
deleted unnecessary project files from github
0ba8cf1
@bekiroguz
added the gitignore file again
da1cad8
@bekiroguz
renamed the first specification as V1
a94f885
Start of the cluster specification
42d72f6
Combine invariants of the nodes for the cluster
91b1a08
@bekiroguz
refactored Cluster spec to support given number of Nodes (needs fix)
a300b78
@bekiroguz
refactored the cluster view and node view specs
781c999
@bekiroguz
start to model the real algorithm in PlusCal
83554e6
@bekiroguz
added all possible states
ab4367e
@bekiroguz
modelled receive unreachable/up messages and also acting on the sbr d…
0754f56 
…ecision. need to fix the unlimited number of states problem still.
@bekiroguz
small changes but still non ending model checking due to state space …
71a1cdb 
…explosion
@bekiroguz
cluster v3 defined with a terminating algorithm
cb2acdf
@bekiroguz
V3: leader is not a global variable but a local to nodes. Each node h…
7bd4984 
…as a perspective of who the leader is.
@bekiroguz
created ClusterV4 with only 3 processes for 3 nodes.
3f055d2
@bekiroguz
ClusterV4 is done.
4e5d6a9
@bekiroguz
using symettic model values, which redices the number of states gener…
e6dd197 
…ated
@bekiroguz
simplified the algorithm, and added NoSplitBrain invariant which hold…
817785b 
…s for all states
@bekiroguz
fixed the ClusterV4 model invariants config in the Toolbox so it fail…
ff5c51e 
…s now.
@bekiroguz
small improvements only
bc38341
@bekiroguz
ClusterV5 with smarter state space generation, and improvements in th…
ec35bef 
…e algorithm
@bekiroguz
ClusterV6 with temporal property
10d892f
@bekiroguz
small cleanup on V6
cfe8641
@bekiroguz
Merge remote-tracking branch 'origin' into split-brain-resolver
8e56808
@bekiroguz
Merge remote-tracking branch 'origin' into split-brain-resolver
7b2d14b
@bekiroguz
Merge remote-tracking branch 'origin' into split-brain-resolver
10223aa
bekiroguz and others added 17 commits November 7, 2018 13:41
@bekiroguz
multi-jvm test setup and initial sbr classes/actors created. multi-jv…
e7f450e 
…m tests are inspired from https://github.com/TanUkkii007/akka-cluster-custom-downing library.
@bekiroguz
small refactoring, still having failing tests.
dbff3e9
@bekiroguz
using cluster.down instead of cluster.leave fixes the tests
36d5f71
@bekiroguz
another test setup added using the mocked (puppet) failure detector
1c6db3e
@bekiroguz
multi-jvm tests with the real network split between nodes
db7d18a
Test that the node with smallest unique address survives a equal split
176f768
Refactor the split brain resolver
2b7244a
Add test to proof that hickups can mess with the decision
4bb0791
Add hick up test
ee48d74
@bekiroguz
use the puppet failure detector in the HickUp test. Small code improv…
ca1a702 
…ements.
@bekiroguz
moved all split brain resolver code and tests from runtime into its o…
274f4ea 
…wn module.
@bekiroguz
Merge branch 'master' into split-brain-resolver
3f9f6d7
@bekiroguz
moved all tls files from root to split-brain-resolver module
992d5d3
@bekiroguz
removed other third party split-brain-resolver dependency.
279b84c
@bekiroguz
small refactoring on log messages
932b412
@bekiroguz
renamed down-removal-margin config to stable-after and added document…
fe85aab 
…ation.
@bekiroguz
Merge branch 'master' into split-brain-resolver
ffa1bfd
merlijn
merlijn reviewed Nov 29, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 29, 2018 •
edited
Loading

Codecov Report

Merging #178 into master will decrease coverage by 1.81%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   83.46%   81.65%   -1.82%     
==========================================
  Files         102      106       +4     
  Lines        2655     2714      +59     
  Branches      124      132       +8     
==========================================
  Hits         2216     2216              
- Misses        439      498      +59
Impacted Files Coverage Δ
...ng/baker/runtime/actor/downing/ClusterHelper.scala 0% <0%> (ø)
...untime/actor/downing/SplitBrainResolverActor.scala 0% <0%> (ø)
...ker/runtime/actor/downing/SplitBrainResolver.scala 0% <0%> (ø)
...baker/runtime/actor/downing/MajorityStrategy.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007d18b...0cf0a43. Read the comment docs.

@merlijn merlijn merged commit f092ac7 into master Nov 30, 2018
@merlijn merlijn deleted the split-brain-resolver branch November 30, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlijn merlijn merlijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekiroguz @codecov-io @merlijn