Update public API of ajax & refactor package #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruphin
requested review from
daKmoR,
erikkroes,
gerjanvangeest,
jorenbroekema,
Knorgias,
narzac and
tlouisse
as code owners
🦋 Changeset detectedLatest commit: dc1f47d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TODO: add changeset |
narzac
force-pushed
the
chore/ajax_rename
branch
3 times, most recently
from
3340f23
to
a067308
Compare
narzac
changed the title
narzac
approved these changes
May 11, 2021
jorenbroekema
requested changes
May 11, 2021
jorenbroekema
requested changes
May 11, 2021
jorenbroekema
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Ajax API to
ajax.fetch()instead ofajax.request()