-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added file last modified validator #2096
Open
labibismaiel
wants to merge
1
commit into
ing-bank:master
Choose a base branch
from
labibismaiel:feature/file-last-modified-validator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
packages/ui/components/form-core/src/validate/FileLastModifiedDateValidator.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,33 @@ | ||||||
import { Validator } from './Validator.js'; | ||||||
|
||||||
export class FileLastModifiedDateValidator extends Validator { | ||||||
static validatorName = 'FileLastModifiedDate'; | ||||||
|
||||||
/** | ||||||
* Checks if the file's last modified date is within the specified range. | ||||||
* @param {Date} fileLastModifiedDate - The file's last modified date. | ||||||
* @param {Date} startDate - The start date of the allowed range. | ||||||
* @param {Date} endDate - The end date of the allowed range. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* @returns {boolean} | ||||||
*/ | ||||||
static isDateWithinRange(fileLastModifiedDate, startDate, endDate) { | ||||||
return fileLastModifiedDate >= startDate && fileLastModifiedDate <= endDate; | ||||||
} | ||||||
|
||||||
/** | ||||||
* @param {Array<File>} modelValue - Array of file objects. | ||||||
* @param {{ startDate: Date; endDate: Date; }} params - Validation parameters. | ||||||
* @returns {boolean} | ||||||
*/ | ||||||
execute(modelValue, params = this.param) { | ||||||
const ctor = /** @type {typeof FileLastModifiedDateValidator} */ (this.constructor); | ||||||
return modelValue.every(file => { | ||||||
const fileDate = new Date(file.lastModified); | ||||||
return ctor.isDateWithinRange(fileDate, params.startDate, params.endDate); | ||||||
}); | ||||||
} | ||||||
|
||||||
static async getMessage() { | ||||||
return 'The file must have been last modified within the specified date range.'; | ||||||
} | ||||||
} |
40 changes: 40 additions & 0 deletions
40
packages/ui/components/form-core/test/validate/FileLastModifiedDateValidator.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { expect } from '@open-wc/testing'; | ||
import { FileLastModifiedDateValidator } from '@lion/ui/FileLastModifiedDateValidator'; | ||
|
||
describe('FileLastModifiedDateValidator', () => { | ||
let validator; | ||
|
||
beforeEach(() => { | ||
validator = new FileLastModifiedDateValidator({ | ||
startDate: new Date('2022-01-01'), | ||
endDate: new Date('2023-01-01'), | ||
}); | ||
}); | ||
|
||
it('validates files within the specified date range', () => { | ||
const validFile = new File(['content'], 'test.txt', { | ||
type: 'text/plain', | ||
lastModified: new Date('2022-06-01').getTime(), | ||
}); | ||
|
||
const result = validator.execute([validFile]); | ||
expect(result).to.be.true; | ||
}); | ||
|
||
it('invalidates files outside the specified date range', () => { | ||
const invalidFile = new File(['content'], 'test.txt', { | ||
type: 'text/plain', | ||
lastModified: new Date('2021-12-31').getTime(), | ||
}); | ||
|
||
const result = validator.execute([invalidFile]); | ||
expect(result).to.be.false; | ||
}); | ||
|
||
it('returns a validation message for invalid files', async () => { | ||
const message = await FileLastModifiedDateValidator.getMessage(); | ||
expect(message).to.equal( | ||
'The file must have been last modified within the specified date range.', | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this inline with other date validators