Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): native submit event should not trigger an error #44

Merged
merged 1 commit into from
May 15, 2019
Merged

fix(form): native submit event should not trigger an error #44

merged 1 commit into from
May 15, 2019

Conversation

daKmoR
Copy link
Collaborator

@daKmoR daKmoR commented May 15, 2019

closes #42

bashmish
bashmish previously requested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@bashmish bashmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns about submit event triggering event listeners twice now.

packages/form/src/LionForm.js Show resolved Hide resolved
packages/form/test/lion-form.test.js Outdated Show resolved Hide resolved
@daKmoR daKmoR dismissed bashmish’s stale review May 15, 2019 14:09

everything implemented

@daKmoR daKmoR merged commit f2c4433 into master May 15, 2019
@daKmoR daKmoR deleted the fix/formSubmit branch May 15, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerjanvangeest gerjanvangeest gerjanvangeest approved these changes

@bashmish bashmish bashmish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lion-form] throws error on submitted
3 participants
@daKmoR @bashmish @gerjanvangeest