Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Constraint to currency on Journals and account. #136

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

ValentinoDefelice
Copy link

  • The currency can't be the same than company on Journals or Account.
    [ADD] Create account_account model file.
    [FIX] Update README.

@coveralls
Copy link

coveralls commented Oct 25, 2018

Coverage Status

Coverage increased (+0.2%) to 40.333% when pulling 52b1113 on adhoc-dev:11.0-h-14357-vd into 8231e91 on ingadhoc:11.0.

Copy link
Contributor

@nicomacr nicomacr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

Copy link
Contributor

@nicomacr nicomacr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valentino please check pylint and flake8 bugs in travis

@@ -0,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValentinoDefelice please remove this file from this PR

nicomacr
nicomacr previously approved these changes Oct 25, 2018
Valentino and others added 2 commits November 21, 2018 15:32
* The currency can't be the same than company on Journals or Account.
[ADD] Create account_account model file.
[FIX] Update README.
@jjscarafia jjscarafia merged commit a20312f into ingadhoc:11.0 Nov 21, 2018
@jjscarafia jjscarafia deleted the 11.0-h-14357-vd branch November 21, 2018 18:32
filoquin pushed a commit to quilsoft-org/account-financial-tools that referenced this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants