[REL] Migration project_stage to 11.0 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicomacr
commented
Jun 14, 2018
nicomacr
commented
- [FIX] Readme
- [FIX] change the name of the xml views files
- [FIX] some minor code fixes
* [FIX] Readme * [FIX] change the name of the xml views files * [FIX] some minor code fixes * [FIX] separe project.py into diferent files
nicomacr
force-pushed
the
11.0-t-9870-nmr
branch
from
878a33c
to
8b8ac4b
Compare
Codecov Report
@@ Coverage Diff @@
## 11.0 #62 +/- ##
=====================================
Coverage ? 100%
=====================================
Files ? 2
Lines ? 16
Branches ? 0
=====================================
Hits ? 16
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
zaoral
suggested changes
Jun 15, 2018
| @@ -0,0 +1,45 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
| <record id="project_form" model="ir.ui.view"> | |||
There was a problem hiding this comment.
- id project_stage_form
- name project.stage.form
project_stage/README.rst
Outdated
| :alt: License: AGPL-3 | ||
|
|
||
| ============= | ||
| Project Stage | ||
| ============= | ||
|
|
||
| Create module project stage and add it on project header form and project search. | ||
| This module create class project stage and add it on project header form and project search. |
There was a problem hiding this comment.
- use model instead of class
- Capitalize the name of the new model
- This is more a technical description than a functional one. This one should be change to something like:
This module create a new model Project Stage that let us to manage project lifecycle more
than just active/inactive status. This new stages works like Tasks Stage original model from
Odoo were we can add sequences, fold stages, kanban status, etc
project_stage/README.rst
Outdated
| :alt: License: AGPL-3 | ||
|
|
||
| ============= | ||
| Project Stage | ||
| ============= | ||
|
|
||
| Create module project stage and add it on project header form and project search. | ||
| This module create class project stage and add it on project header form and project search. | ||
|
|
||
| Installation | ||
| ============ | ||
|
|
There was a problem hiding this comment.
This sections are empty, will be good if they have content as it is in the README guideline template.
Would be good if could look like the next one:
| <field name="stage_id" string="Stage"/> | ||
| </field> | ||
| <group expand="0"> | ||
| <filter string="Stage" name="stage_id" help="Stage" context="{'group_by':'stage_id'}"/> |
There was a problem hiding this comment.
name="stage_id"
filter name group_by_stage or group_by_stage_id
| <field name="name">project.stage.form</field> | ||
| <field name="model">project.stage</field> | ||
| <field name="arch" type="xml"> | ||
| <form string="Task Stage"> |
There was a problem hiding this comment.
<form string="Task Stage">
Project Stage
| </field> | ||
| </record> | ||
| <record id="action_project_stage" model="ir.actions.act_window"> | ||
| <field name="name">Stages</field> |
There was a problem hiding this comment.
<field name="name">Stages</field>
I think that should be Project Stages in order to do not confuse the menu with the Task Stages.
* [FIX] Update Readme * [FIX] some minor views fixes
zaoral
approved these changes
Jun 18, 2018
mlaitinen
pushed a commit
to avoinsystems/project
that referenced
this pull request
Oct 2, 2018
* [REL] Migration project_stage to 11.0 * [FIX] Readme * [FIX] change the name of the xml views files * [FIX] some minor code fixes * [FIX] separe project.py into diferent files * [FIX] some fixes * [FIX] Update Readme * [FIX] some minor views fixes
mlaitinen
pushed a commit
to avoinsystems/project
that referenced
this pull request
Nov 7, 2018
* [REL] Migration project_stage to 11.0 * [FIX] Readme * [FIX] change the name of the xml views files * [FIX] some minor code fixes * [FIX] separe project.py into diferent files * [FIX] some fixes * [FIX] Update Readme * [FIX] some minor views fixes
Menestrels
pushed a commit
to avoinsystems/project
that referenced
this pull request
Feb 26, 2020
* [REL] Migration project_stage to 11.0 * [FIX] Readme * [FIX] change the name of the xml views files * [FIX] some minor code fixes * [FIX] separe project.py into diferent files * [FIX] some fixes * [FIX] Update Readme * [FIX] some minor views fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.