Fix: Docs, Curve generation script #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfelder
requested review from
guy-ingo and
DmytroTym
and removed request for
guy-ingo
guy-ingo
previously approved these changes
Jun 13, 2023
| return Field { CONFIG::one }; | ||
| } | ||
|
|
||
| if (logn > CONFIG::omegas_count) { |
There was a problem hiding this comment.
actually here we can really just return the inverse of logn (it's different than the functions above, where you really don't have an appropriate value to return).
This reverts commit 5c084f6.
guy-ingo
approved these changes
Jun 28, 2023
vhnatyk
requested changes
Jun 28, 2023
vhnatyk
approved these changes
Jun 28, 2023
|
One question: why is there no |
DmytroTym
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR:
Linked Issues
Resolves #101