Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Make i_squared and i_squared_is_negative configurable #113

Closed
jeremyfelder opened this issue Jun 28, 2023 · 0 comments
Closed

[FEAT]: Make i_squared and i_squared_is_negative configurable #113

jeremyfelder opened this issue Jun 28, 2023 · 0 comments
Assignees
@DmytroTym
Labels
type:feature New feature or request

Comments

@jeremyfelder
Copy link
Collaborator

jeremyfelder commented Jun 28, 2023 •
edited
Loading

Description

Make i_squared and i_squared_is_negative configurable from each curve's parameter json file and update the new curve script to correctly templatize these params.

See here for more information: #102 (comment)
@jeremyfelder jeremyfelder added the type:feature New feature or request label Jun 28, 2023
@DmytroTym DmytroTym mentioned this issue Oct 18, 2023
Merged
jeremyfelder pushed a commit that referenced this issue Oct 21, 2023
@liuxiaobleach @DmytroTym @ImmanuelSegol
Support bw6-761 (#188)
fd62fe5 
Resolves #191 and #113

---------

Co-authored-by: DmytroTym <dmytrotym1@gmail.com>
Co-authored-by: ImmanuelSegol <3ditds@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmytroTym DmytroTym

Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmytroTym @jeremyfelder