-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bw6-761 #188
Support bw6-761 #188
Conversation
BW6-671 added with some extra fixes
I'll try to explain my latest commit and since it's quite a bit of code, I'll mention people who wrote the code I modified or are otherwise necessary to ask |
This is fine. I think those functions were missing from this curve since we haven't run the generation script on all curves in a little bit.
I assume you are talking about Rust tests. Makes sense from flipped twiddles. Shouldn't be too difficult to add an option to reverse the twiddles in the short term. Long term we the solution of generating twiddles on the fly. |
bw6761 golang wrapper
Format and slight readme fix
Rust tests sorted out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a fully complete implementation of BW6-671 as Rust wrappers are still missing, but for the sake of C++ and Golang I think this can be merged into main. One slight issue I have with Golang wrappers is that the tests are pretty weak and don't cover all functionality as well as don't check correctness agains gnark (or any other CPU library). This is because interaction with gnark has been factored into the iciclegnark repo.
Either way, we have correctness in gnark's groth16 prover, and IMO it's best to address aforementioned issues as part of the new API.
BLS12-377 twiddles fixed
8b40b3d
No description provided.