Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ReportVersions::Tiny with Test::ReportPrereqs #2

Conversation

paultcochrane
Copy link

ReportVersions::Tiny is deprecated; Test::ReportPrereqs is the
recommended alternative. This change replaces the deprecated plugin with
the recommended plugin in dist.ini. Although this replacement had been
made in version 0.0.5, the change in dist.ini had been missed which was
causing users of the bundle to still use ReportVersions::Tiny. It could,
however, be possible that the issue is actually caused by the 0.0.4 version
being considered by CPAN to be the version to use rathern than the 0.0.5
version. Nevertheless, this change, coupled with a new release, would help
many downstream users as well as close RT issue #103820.

This pull request is submitted in the hope that it is useful. If you have any questions or comments, please don't hesitate to let me know. If any changes are required, I can update the pull request and resubmit.

`ReportVersions::Tiny` is deprecated; `Test::ReportPrereqs` is the
recommended alternative.  This change replaces the deprecated plugin with
the recommended plugin in `dist.ini`.  Although this replacement had been
made in version 0.0.5, the change in `dist.ini` had been missed which was
causing users of the bundle to still use `ReportVersions::Tiny`.  It could,
however, be possible that the issue is actually caused by the 0.0.4 version
being considered by CPAN to be the version to use rathern than the 0.0.5
version.  Nevertheless, this change, coupled with a new release, would help
many downstream users as well as close RT issue #103820.
@dolmen
Copy link
Collaborator

dolmen commented Aug 29, 2016

👍 says the ReportVersions::Tiny maintainer (myself).

But note that the version requirement of '0' is not helpful to make reproducible builds.

@paultcochrane
Copy link
Author

But note that the version requirement of '0' is not helpful to make reproducible builds.

Agreed. I used a version requirement of '0' to match the other version requirements in the plugin bundle, so thought that would be the best way to go. Any particular version which would be appropriate in this case (other than the most recent one)?

@dolmen
Copy link
Collaborator

dolmen commented Aug 31, 2016

The most recent one (0.025) is appropriate because the plugin generates code that is bundled in the distribution using this plugin via this bundle. It is important that this generated code has all the known fixes.

@ingydotnet ingydotnet merged commit 180dae0 into ingydotnet:master Aug 31, 2016
@ingydotnet
Copy link
Owner

Applied. Pushed. Thanks.

@dolmen
Copy link
Collaborator

dolmen commented Sep 2, 2016

For your information I just pushed a serie of 10 commits to completely modernize the bundle implementation: most manual prereqs are removed, and replaced by automatic injection by BundleDeps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants