Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git subrepo status doesn't show subrepos that have a common prefix #534

Closed
cciocov opened this issue May 19, 2021 · 6 comments
Closed

git subrepo status doesn't show subrepos that have a common prefix #534

cciocov opened this issue May 19, 2021 · 6 comments
Labels

Comments

@cciocov
Copy link
Contributor

cciocov commented May 19, 2021

If you have 2 subrepos named "aaa" and "aa", running "git subrepo status" would only show the "aa" subrepo and omit "aaa".

@admorgan
Copy link
Collaborator

Good catch. I created a test and am able to reproduce your issue.

@admorgan admorgan added the Bug label May 19, 2021
@admorgan
Copy link
Collaborator

Good news is that you can do operations on the aaa repo, but it is still a bug that has been hiding since the beginning.

@cciocov cciocov mentioned this issue Jun 15, 2021
@realnc
Copy link

realnc commented Oct 26, 2021

Hit the same issue. My opusfile subrepo is not showing because of the opus subrepo. Same for my SDL surepos. The sdl subrepo hides sdl_net for example or any other sdl_* subrepo.

Quite annoying, but fortunately they're still functional.

@ilCatania
Copy link

additionally, any operation with the --all flag will skip all the subrepos that share the same prefix as the name of an existing subrepo. For example, keeping in line with this issues' original example, doing git subrepo pull --all will pull aa but not aaa. It still works if you pull aaa explicitly though.

@admorgan
Copy link
Collaborator

What version are you using? There hasn't been a release for w while, but PR #536 addressed these issues for me. They are on the release/0.4.5 branch

@admorgan
Copy link
Collaborator

Nevermind, just looked and it is on my local release/0.4.5 branch, but is still pointing to the wrong branch on the actual PR. I will rebase it and push it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants