forked from facebook/mysql-5.6
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add stall counters to 'SHOW GLOBAL STATUS' output. (facebook#695)
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
- Loading branch information
Showing
5 changed files
with
153 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule rocksdb
updated
15 files
+7 −0 | HISTORY.md | |
+6 −17 | cache/lru_cache.cc | |
+1 −1 | db/db_impl.cc | |
+3 −3 | db/db_impl.h | |
+34 −0 | db/db_range_del_test.cc | |
+3 −3 | db/db_test.cc | |
+5 −5 | db/db_test2.cc | |
+48 −9 | db/internal_stats.cc | |
+8 −6 | db/internal_stats.h | |
+2 −2 | db/range_del_aggregator.cc | |
+2 −2 | include/rocksdb/db.h | |
+27 −0 | include/rocksdb/env.h | |
+3 −3 | include/rocksdb/utilities/stackable_db.h | |
+1 −1 | include/rocksdb/version.h | |
+3 −1 | port/port_posix.cc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters