Fix #247 : set return code so ResourceWarning is not emited with pyth…

…on >3.5
inkcut · May 25, 2020 · ba284a1 · ba284a1
1 parent a82aeb2
commit ba284a1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/plugins/inkscape/inkcut_cut.py b/plugins/inkscape/inkcut_cut.py
@@ -81,6 +81,12 @@ def effect(self):
                              close_fds=sys.platform != "win32")
         p.stdin.write(etree.tostring(document) if VERSION == "1.X" else inkex.etree.tostring(document))
         p.stdin.close()
+
+        # Set the returncode to avoid this warning when popen is garbage collected:
+        # "ResourceWarning: subprocess XXX is still running".
+        # See https://bugs.python.org/issue38890 and
+        # https://bugs.python.org/issue26741.
+        p.returncode = 0
 
 if VERSION == "1.X":
     if __name__ == '__main__':

diff --git a/plugins/inkscape/inkcut_open.py b/plugins/inkscape/inkcut_open.py
@@ -71,7 +71,11 @@ def effect(self):
                              close_fds=sys.platform != "win32")
         p.stdin.write(etree.tostring(document) if VERSION == "1.X" else inkex.etree.tostring(document))
         p.stdin.close()
-
+        # Set the returncode to avoid this warning when popen is garbage collected:
+        # "ResourceWarning: subprocess XXX is still running".
+        # See https://bugs.python.org/issue38890 and
+        # https://bugs.python.org/issue26741.
+        p.returncode = 0
 
 if VERSION == "1.X":
     if __name__ == '__main__':