Feature/convert to monolith #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
shunsukew
reviewed
May 29, 2023
There was a problem hiding this comment.
Repository structure has been changed, README updates also needed in my opinion.
There was a problem hiding this comment.
I'll update readme (and docs) once this, ESM and the patches are merged, so I don't have to rewrite it 3 times
(or rather make a readme PR on top of those)
shunsukew
approved these changes
May 30, 2023
|
Any impacts on ecosystem toolings using core packages? |
The package name will be different (@astar-network/swanky-cli), but the exports should stay the same. |
codespool
added a commit
that referenced
this pull request
May 30, 2023
This updates the module system to ESM, and updates all the dependencies. Some additional changes: - __dirname global does not exist anymore in ESM, patched with file url api - max node version that can be safely used for now is v19 (v20 has breaking change with loader modules that are used by ts-node) - @types/node kept at v18 (no spec for v19) - ./bin/dev.js does not work because of ts-node error, will create a watcher and an npm script to rebuild and use ./bin/run.js instead (if solution is not found) This will be kept in draft until #164 is merged, and this rebased to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a monorepo setup didn't really show much benefit, and likely contributed to the @polkadot/* dependency confusion and issues.
I believe reverting back to the monolith setup and exposing the utility functions that are likely to be used by other projects will lead to simpler and more maintainable project. (and also simplify the switch to ESM.
NOTE FOR REVIEW: