Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/convert to esm #165

Merged
merged 23 commits into from
May 30, 2023
Merged

Feature/convert to esm #165

merged 23 commits into from
May 30, 2023

Conversation

codespool
Copy link
Collaborator

This updates the module system to ESM, and updates all the dependencies.

Some additional changes:

  • __dirname global does not exist anymore in ESM, patched with file url api
  • max node version that can be safely used for now is v19 (v20 has breaking change with loader modules that are used by ts-node)
  • @types/node kept at v18 (no spec for v19)
  • ./bin/dev.js does not work because of ts-node error, will create a watcher and an npm script to rebuild and use ./bin/run.js instead (if solution is not found)

This will be kept in draft until #164 is merged, and this rebased to master.

@codespool codespool mentioned this pull request May 25, 2023
Merged
Base automatically changed from feature/convert-to-monolith to master May 30, 2023 11:43
@codespool codespool marked this pull request as ready for review May 30, 2023 11:43
@codespool codespool merged commit e823a13 into master May 30, 2023
2 of 3 checks passed
@codespool codespool deleted the feature/convert-to-esm branch May 30, 2023 12:00
codespool added a commit that referenced this pull request May 30, 2023
@codespool
Fix/deployment gas issue (#166)
0d70e54 
This fixes #161 

- add `WeightV2` type construct to deploy command
- make maxGas flag optional
- some small changes to the test template. (doesn't change how it works,
just locks the mocharc file to the one in the root directory, and
prevents it from looking into parent dir)

Will be promoted from draft after #165 is merged and this rebased to
master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunsukew shunsukew shunsukew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codespool @shunsukew