Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/deployment gas issue #166

Merged
merged 6 commits into from
May 30, 2023
Merged

Fix/deployment gas issue #166

merged 6 commits into from
May 30, 2023

Conversation

codespool
Copy link
Collaborator

This fixes #161

  • add WeightV2 type construct to deploy command
  • make maxGas flag optional
  • some small changes to the test template. (doesn't change how it works, just locks the mocharc file to the one in the root directory, and prevents it from looking into parent dir)

Will be promoted from draft after #165 is merged and this rebased to master

@codespool codespool linked an issue May 25, 2023 that may be closed by this pull request
Add dry run and automatic gas cost to deploy command #154
Closed
@codespool codespool mentioned this pull request May 25, 2023
Merged
@shunsukew
Copy link
Contributor

I'm still getting OutOfGas error.
Screen Shot 2023-05-30 at 10 47 57

Base automatically changed from feature/convert-to-esm to master May 30, 2023 12:00
@codespool codespool marked this pull request as ready for review May 30, 2023 12:06
@codespool
Copy link
Collaborator Author

I'm still getting OutOfGas error. Screen Shot 2023-05-30 at 10 47 57

Hm, I just tested both with and without -g flag:
image

Are you sure you rebuilt the project when you checked out this PR?
(I rebased now, so the yarn dev command also works)

@codespool
use constant for default gas
5c5ca79
@codespool
fix: remove double template processing (#167)
922332e 
Templates were being processed twice, making the second run irrelevant.

This moves the processing to after all the needed data has been
collected.

Also removes the custom `if_eq` helper that's not needed anymore since
there's no language choices.


Will be promoted from draft after #166 is merged and this rebased to
master.
@codespool
update test config
d2e643c
@codespool
Merge branch 'fix/deployment-gas-issue' of https://github.com/AstarNe…
dda0a42 
…twork/swanky-cli into fix/deployment-gas-issue
@shunsukew
Copy link
Contributor

I'm still getting OutOfGas error. Screen Shot 2023-05-30 at 10 47 57

Hm, I just tested both with and without -g flag: image

Are you sure you rebuilt the project when you checked out this PR? (I rebased now, so the yarn dev command also works)

Sorry it was my mistake. deploy works as expected.

@shunsukew shunsukew self-requested a review May 30, 2023 13:34
@codespool codespool merged commit 0d70e54 into master May 30, 2023
3 checks passed
@codespool codespool deleted the fix/deployment-gas-issue branch May 30, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunsukew shunsukew shunsukew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@codespool @shunsukew