Faucet feature for SwankyNode #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n account is created
6 tasks
ipapandinas
requested changes
Jan 24, 2024
ipapandinas
approved these changes
Jan 26, 2024
pmikolajczyk41
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
when running the balance command I get a bit vague error:
$ ../bin/run.js account balance
TypeError: Cannot read properties of undefined (reading 'error')
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
if that's not a big problem, I would suggest to handle this, so that the user understands clearly that an argument is missing; similar thing touches faucet command
apart from this, works well for me
prxgr4mm3r
commented
Mar 12, 2024
| @@ -0,0 +1,45 @@ | |||
| import { Command } from "@oclif/core"; | |||
There was a problem hiding this comment.
@ipapandinas Why is that class here? Isn't it more logical to put it into src/lib/..? When we use swanky account --help oclif thinks that it is a command.
There was a problem hiding this comment.
The idea of having SwankyAccountCommand is to encapsulate common methods for account commands by inheriting this abstract class. But you are right we should move it, otherwise Oclif discovers it as a command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.