set_simulator_device only quotes the device type if necessary.
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the Xcode 4 and 5 Simulators reject e.g. "'iPhone'" . It went unnoticed that `set_simulator_device` wasn't working for "iPhone" and "iPad" because `subliminal_test` forces the project to build using particular device families and "iPhone" and "iPad" are the default device types for their respective families. Investigation reveals that it's not whitespace but rather punctuation in plist values that requires quoting so that's updated too--now `set_simulator_device` will be able to set the Xcode 5 Simulator to "iPad Retina".
aegolden
added a commit
that referenced
this pull request
Sep 10, 2013
`set_simulator_device` only quotes the device type if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the Xcode 4 and 5 Simulators reject e.g. "'iPhone'" . It went unnoticed
that
set_simulator_devicewasn't working for "iPhone" and "iPad" becausesubliminal_testforces the project to build using particular device familiesand "iPhone" and "iPad" are the default device types for their respective families.
Investigation reveals that it's not whitespace but rather punctuation in plist values
that requires quoting so that's updated too--now
set_simulator_devicewillbe able to set the Xcode 5 Simulator to "iPad Retina".