feat: add husky & lint-staged #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
inkyu0103
commented
May 10, 2023
| @@ -10,7 +10,7 @@ jobs: | |||
| with: | |||
| fetch-depth: 3 | |||
| - name: Install dependencies | |||
| run: cd frontend && npm ci | |||
| run: cd frontend && HUSKY=0 npm ci | |||
There was a problem hiding this comment.
CI 환경에서 Husky를 disable하기 위한 옵션입니다.
inkyu0103
commented
May 10, 2023
| disableSnapshot: true; | ||
| } | ||
| } | ||
| chromatic: { disableSnapshot: true }, |
There was a problem hiding this comment.
더 이상 EmailSend 컴포넌트에 대해 snapshot을 사용하지 않습니다.
inkyu0103
commented
May 10, 2023
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| cd frontend && npx lint-staged -q |
There was a problem hiding this comment.
원래는 npx lint-stage로 사용하였으나, multiple run 처럼 보이는 문제가 발생하여 quite mode 옵션을 사용합니다.
관련 issue : lint-staged/lint-staged#1164 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
husky를 적용하여 commit 시 lint rule을 위반한 내용이 없는지 확인합니다.
관련 이슈
Fix #90
변경사항
코드적으로 변경되는 부분을 작성해주세요
스크린샷