forked from stfalcon-it-academy/front-end-4
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 5 #1
Open
Enterigo
wants to merge
3
commits into
inlen:Lesson-5
Choose a base branch
from
Enterigo:Lesson-5
base: Lesson-5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lesson 5 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ок, дякую за розгорнуту відповідь) h2, не все article і багато інших
моментів робив так, тому що відштовхувався від того що це шматочок
сторінки, а не повністю самостійна. Не знаю чому, таке сприйняття)
12 окт. 2017 г. 6:22 PM пользователь "Vladimir Vevdiuk" <
notifications@github.com> написал:
…
1. Треба підлючити нормалайз
2. Треба поставити правильний порядок підключення css спочатку шрифт,
потім нормалайз аж потім style
3. Весь контент встав в артікл, це ж стаття і інформацію про ню,
просто верхню частину можна виділити як header
4. Чому використав не h1, a h2?
5. Правильно буде перерахувати line-height в коефіцієнт
6. Для того щоб не писати для кожного селектора сімейство шрифтів
можна основний обявити як базовий, тобто дати для html, або article якщо
відноситься до стилів лише статті)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ae5CGFa-g_nbnKStWlXWamd0MOKF-0aZks5sri6dgaJpZM4P1j9->
.
|
Очікую правки) |
Все, змінив)
12 окт. 2017 г. 10:54 PM пользователь "Vladimir Vevdiuk" <
notifications@github.com> написал:
… Очікую правки)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ae5CGLkNhR2WCjtZS5_92LZtE5j5zDsTks5srm6NgaJpZM4P1j9->
.
|
Відібрав ноут у друга, за вихідні все маю зробити xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Значення letter-spacing в фш = 0!