Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for GCE #57

Merged
merged 1 commit into from Feb 9, 2020
Merged

Conversation

utsavanand2
Copy link
Contributor

Add instructions for GCE

Signed-off-by: Utsav Anand utsavanand2@gmail.com

Description

Adds instructions for creating a service account with
gcloud and runing inlets-OSS and inlets-pro

Fixes #55

How are existing users impacted? What migration steps/scripts do we need?

No user impact

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question and change needed

README.md Outdated
inletsctl create -p gce --project-id=$PROJECTID --upstream=http://127.0.0.1:3000 -f=key.json

## Create a TCP tunnel with inlets-pro
inletsctl create -p gce -p $PROJECTID --remote-tcp=127.0.0.1 --tcp-ports=22,80,8080,443 -f=key.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these ports? Shouldn't it be 3000?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infact there should be no upstream flag here. I've got trigger happy with the upcoming tmp-tunnel feature.
Those ports are just to depict the difference between inlets-OSS and inlets-pro, that 300 port is not for the client but for the server I guess?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Adds instructions for creating a service account with
gcloud and runing inlets-OSS and inlets-pro

Fixes inlets#55

Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 6753eb5 into inlets:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of how to configure GCE token
2 participants