Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "visual appearance" when compilation is failing #5258

Closed
hlloreda opened this issue Dec 14, 2022 · 3 comments
Closed

Improve "visual appearance" when compilation is failing #5258

hlloreda opened this issue Dec 14, 2022 · 3 comments
Assignees
Labels
design Issues with a design aspect discussion There is a discussion happening on this issue usability This ticket is related to improved usability

Comments

@hlloreda
Copy link
Contributor

When an error occurs in the export, it is not completely clear for the user if the compilation has succeeded or not. Here is an example:

bash-4.2$ inmanta -vvvv export --export-plugin service_entities_exporter -f loader.cf -e some_environment_id
inmanta.env              INFO     Creating new virtual environment in ./.env
inmanta.compiler         DEBUG    Starting compile
inmanta.module           DEBUG    Parsing took 1.024339 seconds
inmanta.module           INFO     verifying project
inmanta.loader           DEBUG    Loading module: inmanta_plugins
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm.allocation_v2
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm.allocation_v2.entity
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm.allocation_v2.dict_path
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm.allocation_v2.framework
inmanta.protocol.endpointsDEBUG    Start transport for client compiler
inmanta.loader           DEBUG    Loading module: inmanta_plugins.lsm.allocation
inmanta.module           DEBUG    Loading module inmanta_plugins.std
inmanta.loader           DEBUG    Loading module: inmanta_plugins.std
...................................................................................
inmanta.execute.schedulerDEBUG    Finishing statements with no waiters
inmanta.execute.schedulerINFO     Iteration 1 (e: 0, w: 0, p: 0, done: 2917, time: 0.204690)
inmanta.execute.schedulerINFO     Total compilation time 0.412226
inmanta.compiler         DEBUG    Compile done
inmanta.protocol.endpointsDEBUG    Start transport for client compiler
asyncio                  DEBUG    Using selector: EpollSelector
inmanta.protocol.rest.clientDEBUG    Getting config in section compiler_rest_transport
could not upload lifecycle {'message': 'Invalid request: Attribute update not supported for attribute some_random_variable: changing default_value from None to [])'} (code: 400)
bash-4.2$ 

The output could be improved to emphasize encountered errors.

@sanderr sanderr added the discussion There is a discussion happening on this issue label Jan 10, 2023
@sanderr sanderr added enhancement New feature or request usability This ticket is related to improved usability and removed enhancement New feature or request labels May 25, 2023
@sanderr sanderr added the design Issues with a design aspect label Aug 8, 2023
@sanderr
Copy link
Contributor

sanderr commented Aug 8, 2023

Hey team! Please add your planning poker estimate with Zenhub @FloLey @Hugo-Inmanta @wouterdb

@arnaudsjs arnaudsjs self-assigned this Sep 11, 2023
@arnaudsjs
Copy link
Contributor

Follow up ticket: #6489

@arnaudsjs
Copy link
Contributor

Slack discussion about this topic: https://inmanta.slack.com/archives/CKRF0C8R3/p1694527714552199

inmantaci pushed a commit that referenced this issue Sep 28, 2023
…ands to make it more clear to the end-user when the command failed. (Issue #5258, PR #6532)

# Description

Improve visual appearance of the compiler on failure

closes #5258

# Self Check:

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Oct 2, 2023
Part of #5258

# Self Check:

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
inmantaci pushed a commit that referenced this issue Oct 2, 2023
…ands to make it more clear to the end-user when the command failed. (Issue #5258, PR #6532)

Pull request opened by the merge tool on behalf of #6532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues with a design aspect discussion There is a discussion happening on this issue usability This ticket is related to improved usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants