New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "visual appearance" when compilation is failing #5258
Labels
design
Issues with a design aspect
discussion
There is a discussion happening on this issue
usability
This ticket is related to improved usability
Comments
sanderr
added
enhancement
New feature or request
usability
This ticket is related to improved usability
and removed
enhancement
New feature or request
labels
May 25, 2023
Hey team! Please add your planning poker estimate with Zenhub @FloLey @Hugo-Inmanta @wouterdb |
Follow up ticket: #6489 |
Slack discussion about this topic: https://inmanta.slack.com/archives/CKRF0C8R3/p1694527714552199 |
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Sep 28, 2023
…ands to make it more clear to the end-user when the command failed. (Issue #5258, PR #6532) # Description Improve visual appearance of the compiler on failure closes #5258 # Self Check: - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Oct 2, 2023
Part of #5258 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] ~~End user documentation is included or an issue is created for end-user documentation~~ - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
Issues with a design aspect
discussion
There is a discussion happening on this issue
usability
This ticket is related to improved usability
When an error occurs in the export, it is not completely clear for the user if the compilation has succeeded or not. Here is an example:
The output could be improved to emphasize encountered errors.
The text was updated successfully, but these errors were encountered: