Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove first column from compiler output #6489

Closed
arnaudsjs opened this issue Sep 12, 2023 · 1 comment
Closed

Remove first column from compiler output #6489

arnaudsjs opened this issue Sep 12, 2023 · 1 comment
Assignees
@arnaudsjs
Labels
usability This ticket is related to improved usability

Comments

@arnaudsjs
Copy link
Contributor

arnaudsjs commented Sep 12, 2023 •
edited 

inmanta.compiler         DEBUG   Starting compile
inmanta.module           DEBUG   Parsing took 0.003764 seconds
inmanta.parser.cache     DEBUG   Compiler cache observed 2 hits and 0 misses (100%)
inmanta.module           INFO    verifying project
inmanta.module           DEBUG   Loading module inmanta_plugins.std
inmanta.module           DEBUG   Loading module inmanta_plugins.std.resources
inmanta.module           DEBUG   Parsing took 0.000167 seconds
inmanta.parser.cache     DEBUG   Compiler cache observed 2 hits and 0 misses (100%)
inmanta.module           INFO    The following modules are currently installed:
inmanta.module           INFO    V2 modules:
inmanta.module           INFO      std: 4.2.1.dev20230911043312

Should become:

DEBUG   Starting compile
DEBUG   Parsing took 0.003764 seconds
DEBUG   Compiler cache observed 2 hits and 0 misses (100%)
INFO    verifying project
DEBUG   Loading module inmanta_plugins.std
DEBUG   Loading module inmanta_plugins.std.resources
DEBUG   Parsing took 0.000167 seconds
DEBUG   Compiler cache observed 2 hits and 0 misses (100%)
INFO    The following modules are currently installed:
INFO    V2 modules:
INFO      std: 4.2.1.dev20230911043312
@arnaudsjs arnaudsjs added the usability This ticket is related to improved usability label Sep 12, 2023
@arnaudsjs arnaudsjs changed the title Remove first columne from compiler output Remove first column from compiler output Sep 12, 2023
@arnaudsjs arnaudsjs mentioned this issue Sep 12, 2023
Closed
@arnaudsjs
Copy link
Contributor Author

Slack discussion about this topic: https://inmanta.slack.com/archives/CKRF0C8R3/p1694527714552199

@arnaudsjs arnaudsjs self-assigned this Oct 10, 2023
@arnaudsjs arnaudsjs mentioned this issue Oct 17, 2023
Closed
9 tasks
inmantaci pushed a commit that referenced this issue Oct 19, 2023
@arnaudsjs @inmantaci
Improve the output of the inmanta compile and inmanta export comm…
d9aeb99 
…ands, by using the logger name `compiler`, `exporter` or `<name-inmanta-module>` for log records produced by respectively the compiler, the exporter or an Inmanta module. (Issue #6489, PR #6630)

# Description

This PR improves the output of the `inmanta compile` and `inmanta export` commands, by using the logger name `compiler`, `exporter` or `<name-inmanta-module>` for log records produced by respectively the compiler, the exporter or an Inmanta module.

closes #6489

# Self Check:

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
inmantaci pushed a commit that referenced this issue Oct 19, 2023
@arnaudsjs @inmantaci
Improve the output of the inmanta compile and inmanta export comm…
2f924ec 
…ands, by using the logger name `compiler`, `exporter` or `<name-inmanta-module>` for log records produced by respectively the compiler, the exporter or an Inmanta module. (Issue #6489, PR #6630)

Pull request opened by the merge tool on behalf of #6630
Hugo-Inmanta pushed a commit that referenced this issue Nov 6, 2023
@arnaudsjs @Hugo-Inmanta
Improve the output of the inmanta compile and inmanta export comm…
ee8fdf5 
…ands, by using the logger name `compiler`, `exporter` or `<name-inmanta-module>` for log records produced by respectively the compiler, the exporter or an Inmanta module. (Issue #6489, PR #6630)

# Description

This PR improves the output of the `inmanta compile` and `inmanta export` commands, by using the logger name `compiler`, `exporter` or `<name-inmanta-module>` for log records produced by respectively the compiler, the exporter or an Inmanta module.

closes #6489

# Self Check:

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] ~~End user documentation is included or an issue is created for end-user documentation~~
- [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaudsjs arnaudsjs

Labels
usability This ticket is related to improved usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change logger name of compile and export commands inmanta/inmanta-core
1 participant
@arnaudsjs