New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable agent install of dependency modules by default #7026
Comments
Hey team! Please add your planning poker estimate with Zenhub @arnaudsjs @FloLey @Hugo-Inmanta @sanderr |
9 tasks
inmantaci
pushed a commit
that referenced
this issue
Mar 5, 2024
…dules`. The installation of module dependencies is now always enabled. (Issue #7026, PR #7285) # Description This PR enables the project configuration option `agent_install_dependency_modules` by default. closes #7026 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
agent_install_dependency_modules
project option has to be set in all practical models. Therefore it would make sense to phase it out and enable its behavior by default. This requires a few extra steps to make it safe:a
depends onb
a-1.0
andb-1.0
, both of which have resources for this agent. Agent puts code in its code directory.a-1.0
andb-2.0
,b
no longer has resources for this agent. Agent puts code fora
, notb
in its code directory but the old code forb
is still there.b-1.0
is loaded instead ofb-2.0
installed by pip in the venv.All of this is iso7+?
The text was updated successfully, but these errors were encountered: