Re-add the agent_install_dependency_modules project config option #7312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… backwards compatibility
wouterdb
approved these changes
Mar 6, 2024
Hugo-Inmanta
approved these changes
Mar 6, 2024
Hugo-Inmanta
reviewed
Mar 6, 2024
tests/test_loader.py
Outdated
| project._metadata.agent_install_dependency_modules = False | ||
| # reset cache | ||
| source_info._requires = None | ||
| # when enabled, also install dependencies on other modules |
There was a problem hiding this comment.
The comments should also be swapped
Hugo-Inmanta
requested changes
Mar 6, 2024
Hugo-Inmanta
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-add
agent_install_dependency_modulesproject config option for backwards compatibility.Mergetool is going to reject this, because I modified an existing changelog entry. So I will merge this by hand.
Part of #7026
Self Check:
If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)