Added support for Beitian BN-880 module #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2018 17:19
The Beitian BN-880 appears to use slightly different NEMA sentences. By adding these sentences and calling the methods which already exist everything seems to work as expected. This was tested on an ESP32. The extra exception catching was needed to prevent the program from crashing in case a "list index out of range" exception was thrown.
All supported sentences are now in the README file and also a small part on how to use it with an ESP32.
inmcm
reviewed
Feb 3, 2018
README.md
Outdated
| @@ -91,7 +99,7 @@ The timezone can be automatically adjusted for using the by setting the ```local | |||
| (3, 18, 36.0) | |||
| ``` | |||
|
|
|||
| The current UTC date is stored (day,month,year). **NOTE:** The date is not currently adjusted to match the timezone set in ```local_offset```. | |||
There was a problem hiding this comment.
Small nitpick: please avoid whitespace changes as it muddles the git history.
inmcm
reviewed
Feb 3, 2018
micropyGPS.py
Outdated
| @@ -497,21 +497,29 @@ def gpgsv(self): | |||
| sat_id = int(self.gps_segments[sats]) | |||
| except ValueError: | |||
| return False | |||
| except Exception: | |||
There was a problem hiding this comment.
Can you change this to IndexError since that's the exception your commit comment references? You can even just combine them: except (ValueError, IndexError):
inmcm
requested changes
Feb 3, 2018
added 2 commits
February 4, 2018 10:33
The whitespaces which were removed and messed up the git history were added again. Instead of catching all exceptions, we just now just catch the IndexError.
* Added missing whitspaces
|
@inmcm thanks for your feedback! I added the requested changes and it took me some commits until I realised that my editor was removing whitespaces for me :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for this great library!
The Beitian BN-880 is relativly cheap module and works quite good. Unfortunately is uses slightly different NMEA sentences. But these can still be parsed with the already existing methods.
We also tested this on an ESP32 and can confirm that is works, as soon as you precompile it as a frozen module.