Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include builtInMiddleware in custom middleware types #332

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Sep 29, 2023

Summary

When creating middleware, include all internal "built-in" middleware typing, allowing users to access types such as logger to make changes and corrections.

new InngestMiddleware({
  name: "Example Middleware",
  init: () => ({
    onFunctionRun: () => ({
      transformInput: (input) => {
        input.ctx.logger;
        //        ^? (property) logger: Logger
        // This was previously undefined
      },
    }),
  }),
});

Serves as a PoC for part of resolving #331, allowing the user to see and affect the result of internal middleware.

Checklist

  • Added a docs PR that references this PR
  • Added unit/integration tests
  • Added changesets if applicable

Related

@jpwilliams jpwilliams self-assigned this Sep 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

⚠️ No Changeset found

Latest commit: 3dd89aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jpwilliams jpwilliams added the ⬆️ improvement Performance, reliability, or usability improvements label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant