INN-2152 Slim down "pretty errors" before sending to Inngest #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwilliams
added
the
⬆️ improvement
jpwilliams
requested review from
IGassmann,
anafilipadealmeida and
goodoldneon
🦋 Changeset detectedLatest commit: 2ce4507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tonyhb
approved these changes
Oct 16, 2023
tonyhb
deleted the
jack/inn-2152-fix-ugly-error-when-sending-event-without-inngest_event_key
branch
Merged
tonyhb
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.2.1 ### Patch Changes - [#360](#360) [`260dd75`](260dd75) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Inngest errors now appear more succintly in UIs, free of ANSI codes and verbose information Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slims down "pretty errors," whose name is already subjective, before sending them to Inngest, by stripping ANSI codes and removing immediate debugging information.
The UI could access the code being sent (e.g.
AUTOMATIC_PARALLEL_INDEXING), but it's probably nicer to send this code inside serialized errors in the future, allowing the UI to provide hints and links to documentation, inclusive of short links such ashttps://innge.st/ERR_CODE_HERE.Checklist
Added a docs PR that references this PRN/A ImprovementRelated