Fix client allowing extraneous properties upon creation

packages/inngest/src/components/EventSchemas.test.ts

@@ -1,9 +1,10 @@
 import { EventSchemas } from "@local/components/EventSchemas";
-import { Inngest, type GetEvents } from "@local/components/Inngest";
+import { type GetEvents, type Inngest } from "@local/components/Inngest";
 import { type IsAny } from "@local/helpers/types";
 import { type EventPayload } from "@local/types";
 import { assertType, type IsEqual } from "type-plus";
 import { z } from "zod";
+import { createClient } from "../test/helpers";
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type Schemas<T extends EventSchemas<any>> = GetEvents<
@@ -659,7 +660,7 @@ describe("EventSchemas", () => {
         "test.event": { data: { a: string } };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -682,7 +683,7 @@ describe("EventSchemas", () => {
         "test.event": { data: any };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -707,7 +708,7 @@ describe("EventSchemas", () => {
         "test.event2": { data: { foo: string } };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -735,7 +736,7 @@ describe("EventSchemas", () => {
         "test.event2": { data: { bar: boolean } };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -766,7 +767,7 @@ describe("EventSchemas", () => {
         "test.event2": { data: any };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -795,7 +796,7 @@ describe("EventSchemas", () => {
         "test.event2": { data: { foo: string } };
       }>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",
@@ -840,7 +841,7 @@ describe("EventSchemas", () => {
 
       const schemas = new EventSchemas().fromUnion<TestEvent | TestEvent2>();
 
-      const inngest = new Inngest({
+      const inngest = createClient({
         id: "test",
         schemas,
         eventKey: "test-key-123",

packages/inngest/src/components/Inngest.test.ts

@@ -403,6 +403,18 @@ describe("send", () => {
   });
 
   describe("types", () => {
+    describe("instantiation", () => {
+      test("disallows setting unknown config property with object literal", () => {
+        // @ts-expect-error Unknown property
+        const _fn = () => new Inngest({ id: "test", baseURL: "bar" });
+      });
+
+      test("allows setting unknown config property with variable", () => {
+        const options = { id: "test", baseURL: "bar" };
+        const _fn = () => new Inngest(options);
+      });
+    });
+
     describe("no custom types", () => {
       const inngest = createClient({ id: "test", eventKey: testEventKey });
 
@@ -734,7 +746,7 @@ describe("createFunction", () => {
 });
 
 describe("helper types", () => {
-  const inngest = new Inngest({
+  const inngest = createClient({
     id: "test",
     schemas: new EventSchemas().fromRecord<{
       foo: { data: { foo: string } };

packages/inngest/src/components/Inngest.ts

@@ -1,3 +1,4 @@
+import { type Exact } from "type-fest";
 import { InngestApi } from "../api/api";
 import {
   defaultDevServerHost,
@@ -147,15 +148,17 @@ export class Inngest<TOpts extends ClientOptions = ClientOptions> {
    * });
    * ```
    */
-  constructor({
-    id,
-    eventKey,
-    baseUrl,
-    fetch,
-    env,
-    logger = new DefaultLogger(),
-    middleware,
-  }: TOpts) {
+  constructor(options: Exact<ClientOptions, TOpts>) {
+    const {
+      id,
+      eventKey,
+      baseUrl,
+      fetch,
+      env,
+      logger = new DefaultLogger(),
+      middleware,
+    } = options as ClientOptions;
+
     if (!id) {
       // TODO PrettyError
       throw new Error("An `id` must be passed to create an Inngest instance.");

packages/inngest/src/test/helpers.ts

@@ -2,7 +2,7 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/no-unsafe-call */
-import { Inngest } from "@local";
+import { Inngest } from "@local/components/Inngest";
 import { type ServeHandlerOptions } from "@local/components/InngestCommHandler";
 import { envKeys, headerKeys, queryKeys } from "@local/helpers/consts";
 import { type Env } from "@local/helpers/env";
@@ -461,7 +461,7 @@ export const testFramework = (
           const ret = await run(
             [
               {
-                client: new Inngest({ id: "Test", env: "FOO" }),
+                client: createClient({ id: "Test", env: "FOO" }),
                 functions: [],
               },
             ],