Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "No request version" log from warn to debug; previous executor v #369

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Oct 24, 2023

Summary

Ensure the No request version log is a debug log instead of a warning. This does indicate that something might be off with the executor being used, though it won't harm any functionality or performance.

image

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests N/A
  • Added changesets if applicable

@jpwilliams jpwilliams added the ⬆️ improvement Performance, reliability, or usability improvements label Oct 24, 2023
@jpwilliams jpwilliams self-assigned this Oct 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 2426951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tonyhb tonyhb merged commit e1046cd into main Oct 24, 2023
24 checks passed
@tonyhb tonyhb deleted the no-request-version-log branch October 24, 2023 19:25
tonyhb pushed a commit that referenced this pull request Oct 24, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@3.4.0

### Minor Changes

- [#370](#370)
[`48b201a`](48b201a)
Thanks [@tonyhb](https://github.com/tonyhb)! - Update concurrency with
new scopes and multiple keys

### Patch Changes

- [#369](#369)
[`e1046cd`](e1046cd)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Change `No
request version` log from warn to debug

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants