Add INNGEST_API_BASE_URL and INNGEST_EVENT_API_BASE_URL
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwilliams
added
prerelease/inngest
🦋 Changeset detectedLatest commit: 02a1598 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A user has added the prerelease/inngest label, so this PR will be published to npm with the tag You can install this prerelease version with: npm install inngest@pr-378The last release was built and published from 02a1598. |
|
My only thought and open question - should it be |
This is more explicit, which is good.
jpwilliams
changed the title
INNGEST_API_BASE_URL and INNGEST_EVENT_BASE_URLINNGEST_API_BASE_URL and INNGEST_EVENT_API_BASE_URL
darwin67
approved these changes
Nov 3, 2023
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Nov 6, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.4.2 ### Patch Changes - [#378](#378) [`b83f925`](b83f925) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add `INNGEST_API_BASE_URL` and `INNGEST_EVENT_API_BASE_URL`, used for internal testing - [#382](#382) [`0002afa`](0002afa) Thanks [@tonyhb](https://github.com/tonyhb)! - Remove verbose event keys warning Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In addition to
INNGEST_BASE_URL, addsINNGEST_API_BASE_URLandINNGEST_EVENT_API_BASE_URL.No current users should have to use this, but this is useful for our own internal testing.
Checklist
Added a docs PR that references this PRN/A InternalAdded unit/integration testsN/A