Pass serve handler arguments to middleware to access req-only data #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases, a user may want to access the incoming request objects in a way that doesn't affect how Inngest should handle the request. For example, in the case of utilizing Cloudflare AI on Cloudflare Workers, an
Ai
instance is created using theenv
object passed to the request.Currently, arguments being passed to the request handler are used only by the serve handler and aren't exposed to the function. Part of the reason for this is that the serve handler is currently entirely separate from creating functions, so typing request arguments would be difficult.
To resolve this in this PR, we instead pass these arguments to middleware, where we can then assess the request arguments and add properties to our function's input. #383 is used as the problem to solve here.
With this PR, #383 would be resolved using the following middleware:
This would then be used like so:
Checklist
Related
reqArgs
argument in middleware website#623